I'm not too sure about avoiding the short-circuiting. Are there any expensive checks done in this code?

I'm wondering if it would be okay to still short circuit but keep around the index of the update that failed this checking. We'd still at least report the index along with the error.

It seems hashing and I/O are the heavy stuff here.

                        ok_if_vk_hash_expected ~got:vk ~expected:vk_hash

And the invocation to find_vk might be heavy. Here's an example call site in Transaction_pool:

Zkapp_command.Verifiable.create ~failed:false
           ~find_vk:
             (Zkapp_command.Verifiable.load_vk_from_ledger
                ~get:(Mina_ledger.Ledger.get ledger)
                ~location_of_account:
                  (Mina_ledger.Ledger.location_of_account ledger) )
           zkapp_command

                Account_id.Table.update tbl account_id
                  ~f:(const @@ With_hash.hash prioritized_vk) ;

I'll make a follow up commit by making this error check feature optional. So end-user can swap them on if preferred.